netdev - Re: [PATCH 09/12] Bluetooth: use inclusive language in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6BDB11E1-DB4D-4F44-827F-CCED6D876395@holtmann.org>
Date:   Wed, 26 May 2021 17:09:37 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Archie Pusaka <apusaka@...gle.com>
Cc:     linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/12] Bluetooth: use inclusive language in debugfs

Hi Archie,

> Use "accept list" and "reject list".
> 
> Signed-off-by: Archie Pusaka <apusaka@...omium.org>
> Reviewed-by: Miao-chen Chou <mcchou@...omium.org>
> 
> ---
> 
> net/bluetooth/hci_debugfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c
> index 47f4f21fbc1a..3352e831af3d 100644
> --- a/net/bluetooth/hci_debugfs.c
> +++ b/net/bluetooth/hci_debugfs.c
> @@ -138,7 +138,7 @@ static int device_list_show(struct seq_file *f, void *ptr)
> 
> DEFINE_SHOW_ATTRIBUTE(device_list);
> 
> -static int blacklist_show(struct seq_file *f, void *p)
> +static int reject_list_show(struct seq_file *f, void *p)
> {
> 	struct hci_dev *hdev = f->private;
> 	struct bdaddr_list *b;
> @@ -151,7 +151,7 @@ static int blacklist_show(struct seq_file *f, void *p)
> 	return 0;
> }
> 
> -DEFINE_SHOW_ATTRIBUTE(blacklist);
> +DEFINE_SHOW_ATTRIBUTE(reject_list);
> 
> static int blocked_keys_show(struct seq_file *f, void *p)
> {
> @@ -323,7 +323,7 @@ void hci_debugfs_create_common(struct hci_dev *hdev)
> 	debugfs_create_file("device_list", 0444, hdev->debugfs, hdev,
> 			    &device_list_fops);
> 	debugfs_create_file("blacklist", 0444, hdev->debugfs, hdev,
> -			    &blacklist_fops);
> +			    &reject_list_fops);

NAK. We are not changing the file names just yet and so there is no point in changing partial function and ops structure names.

This needs to go in as complete patch if we decide to change the debugfs file name.

Regards

Marcel