netdev - Re: [QUESTION] BPF kernel selftests failed in the LTS stable kernel 4.19.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9671b7f4-b827-3c81-f1e5-2836c701495b@loongson.cn>
Date:   Thu, 27 May 2021 16:18:15 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [QUESTION] BPF kernel selftests failed in the LTS stable kernel
 4.19.x

On 05/27/2021 12:24 PM, Greg Kroah-Hartman wrote:
> On Thu, May 27, 2021 at 10:27:51AM +0800, Tiezhu Yang wrote:
>> Hi all,
>>
>> When update the following LTS stable kernel 4.19.x,
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-4.19.y
>>
>> and then run BPF selftests according to
>> https://www.kernel.org/doc/html/latest/bpf/bpf_devel_QA.html#q-how-to-run-bpf-selftests
>>
>> $ cd tools/testing/selftests/bpf/
>> $ make
>> $ sudo ./test_verifier
>> $ sudo make run_tests
>>
>> there exists many failures include verifier tests and run_tests,
>> (1) is it necessary to make sure that there are no any failures in the LTS
>> stable kernel 4.19.x?
> Yes, it would be nice if that did not happen.
>
>> (2) if yes, how to fix these failures in the LTS stable kernel 4.19.x?
> Can you find the offending commits by using `git bisect` and find the
> upstream commits that resolve this and let us know so we can backport
> them?
>
> thanks,
>
> greg k-h

I compared the related code in 4.19.y and upstream mainline, some failures
disappeared after add ".flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,", but
other failures still exist, and I didn't have enough in-depth knowledge to
touch things elsewhere.

The failures can be easily reproduced, I would greatly appreciate it if 
anyone
is interested to fix them.