netdev - Re: [PATCH net-next v3 0/3] net/sched: act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98780fe0-f34f-277a-f137-543f7ddd5d0c@mojatatu.com>
Date:   Mon, 31 May 2021 08:13:05 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Davide Caratti <dcaratti@...hat.com>,
        Boris Sukholitko <boris.sukholitko@...adcom.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        linux-kselftest@...r.kernel.org, shuah@...nel.org,
        Ilya Lifshits <ilya.lifshits@...adcom.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v3 0/3] net/sched: act_vlan: Fix modify to allow
 0

On 2021-05-31 7:57 a.m., Davide Caratti wrote:
> On Sun, May 30, 2021 at 02:40:49PM +0300, Boris Sukholitko wrote:
>> Currently vlan modification action checks existence of vlan priority by
>> comparing it to 0. Therefore it is impossible to modify existing vlan
>> tag to have priority 0.
> 
> hello Boris, thanks for following up!
>   
>> Change Log:
>> v2 -> v3:
>> - Push assumes that the priority is being set
>> - tcf_vlan_get_fill_size accounts for priority existence
> 
> Reviewed-by: Davide Caratti <dcaratti@...hat.com>
> 

Looks good to me as well. And thanks for adding the tests!

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal