netdev - Re: [PATCH net] selftests/wireguard: make sure rp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9rYp0iO_=c_+UxvU9+UpHnnGkQVJYoikyjwav04UwZwBQ@mail.gmail.com>
Date:   Mon, 31 May 2021 14:39:36 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] selftests/wireguard: make sure rp_filter disabled on vethc

On Tue, May 25, 2021 at 2:15 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> Some distros may enable strict rp_filter by default, which will previent
> vethc receive the packets with unrouteable reverse path address.
>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/wireguard/netns.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/wireguard/netns.sh b/tools/testing/selftests/wireguard/netns.sh
> index 7ed7cd95e58f..37b12f642254 100755
> --- a/tools/testing/selftests/wireguard/netns.sh
> +++ b/tools/testing/selftests/wireguard/netns.sh
> @@ -363,6 +363,7 @@ ip1 -6 rule add table main suppress_prefixlength 0
>  ip1 -4 route add default dev wg0 table 51820
>  ip1 -4 rule add not fwmark 51820 table 51820
>  ip1 -4 rule add table main suppress_prefixlength 0
> +n1 sysctl -w net.ipv4.conf.vethc.rp_filter=0

The VM does not ship with sysctl, and you'll notice that other changes
go through /proc directly. Since it's a trivial change, I'll rewrite
your commit.

Jason