netdev - Re: [PATCH ipsec] xfrm: remove the fragment check for ipv6 beet mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210603081816.GY40979@gauss3.secunet.de>
Date:   Thu, 3 Jun 2021 10:18:16 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, <kuba@...nel.org>,
        Sabrina Dubroca <sd@...asysnail.net>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec] xfrm: remove the fragment check for ipv6 beet mode

On Sat, May 29, 2021 at 04:23:18PM -0400, Xin Long wrote:
> In commit 68dc022d04eb ("xfrm: BEET mode doesn't support fragments
> for inner packets"), it tried to fix the issue that in TX side the
> packet is fragmented before the ESP encapping while in the RX side
> the fragments always get reassembled before decapping with ESP.
> 
> This is not true for IPv6. IPv6 is different, and it's using exthdr
> to save fragment info, as well as the ESP info. Exthdrs are added
> in TX and processed in RX both in order. So in the above case, the
> ESP decapping will be done earlier than the fragment reassembling
> in TX side.
> 
> Here just remove the fragment check for the IPv6 inner packets to
> recover the fragments support for BEET mode.
> 
> Fixes: 68dc022d04eb ("xfrm: BEET mode doesn't support fragments for inner packets")
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks Xin!