netdev - Re: [PATCH] net/ieee802154: drop unneeded assignment in llsec_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bffca3c-6c85-b975-24d4-cdd1aa47380e@datenfreihafen.org>
Date:   Thu, 3 Jun 2021 10:21:09 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, alex.aring@...il.com
Cc:     davem@...emloft.net, kuba@...nel.org, linux-wpan@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ieee802154: drop unneeded assignment in
 llsec_iter_devkeys()

Hello.

On 25.04.21 12:24, Yang Li wrote:
> In order to keep the code style consistency of the whole file,
> redundant return value ‘rc’ and its assignments should be deleted
> 
> The clang_analyzer complains as follows:
> net/ieee802154/nl-mac.c:1203:12: warning: Although the value stored to
> 'rc' is used in the enclosing expression, the value is never actually
> read from 'rc'
> 
> No functional change, only more efficient.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   net/ieee802154/nl-mac.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
> index 0c1b077..a6a8cf6 100644
> --- a/net/ieee802154/nl-mac.c
> +++ b/net/ieee802154/nl-mac.c
> @@ -1184,7 +1184,7 @@ static int llsec_iter_devkeys(struct llsec_dump_data *data)
>   {
>   	struct ieee802154_llsec_device *dpos;
>   	struct ieee802154_llsec_device_key *kpos;
> -	int rc = 0, idx = 0, idx2;
> +	int idx = 0, idx2;
>   
>   	list_for_each_entry(dpos, &data->table->devices, list) {
>   		if (idx++ < data->s_idx)
> @@ -1200,7 +1200,7 @@ static int llsec_iter_devkeys(struct llsec_dump_data *data)
>   						      data->nlmsg_seq,
>   						      dpos->hwaddr, kpos,
>   						      data->dev)) {
> -				return rc = -EMSGSIZE;
> +				return -EMSGSIZE;
>   			}
>   
>   			data->s_idx2++;
> @@ -1209,7 +1209,7 @@ static int llsec_iter_devkeys(struct llsec_dump_data *data)
>   		data->s_idx++;
>   	}
>   
> -	return rc;
> +	return 0;
>   }
>   
>   int ieee802154_llsec_dump_devkeys(struct sk_buff *skb,
> 

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt