netdev - Re: [PATCH v1 1/1] mrf29j40: Drop unneeded of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 10:34:24 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Alan Ott <alan@...nal11.us>,
        Alexander Aring <alex.aring@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v1 1/1] mrf29j40: Drop unneeded of_match_ptr()

Hello.

On 31.05.21 15:22, Andy Shevchenko wrote:
> Driver can be used in different environments and moreover, when compiled
> with !OF, the compiler may issue a warning due to unused mrf24j40_of_match
> variable. Hence drop unneeded of_match_ptr() call.
> 
> While at it, update headers block to reflect above changes.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index b9be530b285f..ff83e00b77af 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -8,8 +8,8 @@
>   
>   #include <linux/spi/spi.h>
>   #include <linux/interrupt.h>
> +#include <linux/mod_devicetable.h>
>   #include <linux/module.h>
> -#include <linux/of.h>
>   #include <linux/regmap.h>
>   #include <linux/ieee802154.h>
>   #include <linux/irq.h>
> @@ -1388,7 +1388,7 @@ MODULE_DEVICE_TABLE(spi, mrf24j40_ids);
>   
>   static struct spi_driver mrf24j40_driver = {
>   	.driver = {
> -		.of_match_table = of_match_ptr(mrf24j40_of_match),
> +		.of_match_table = mrf24j40_of_match,
>   		.name = "mrf24j40",
>   	},
>   	.id_table = mrf24j40_ids,
> 

I took the freedom to fix the typo in the subject line and add a better 
prefix:

net: ieee802154: mrf24j40: Drop unneeded of_match_ptr()

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt