netdev - Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLqPnpNXbd6o019o@lunn.ch>
Date:   Fri, 4 Jun 2021 22:39:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Liang Xu <lxu@...linear.com>
Cc:     "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Thomas Mohren <tmohren@...linear.com>
Subject: Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver

On Fri, Jun 04, 2021 at 12:52:02PM +0000, Liang Xu wrote:
> On 4/6/2021 8:15 pm, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> >> +config MXL_GPHY
> >> +     tristate "Maxlinear PHYs"
> >> +     help
> >> +       Support for the Maxlinear GPY115, GPY211, GPY212, GPY215,
> >> +       GPY241, GPY245 PHYs.
> > Do these PHYs have unique IDs in register 2 and 3? What is the format
> > of these IDs?
> >
> > The OUI is fixed. But often the rest is split into two. The higher
> > part indicates the product, and the lower part is the revision. We
> > then have a struct phy_driver for each product, and the mask is used
> > to match on all the revisions of the product.
> >
> >       Andrew
> >
> Register 2, Register 3 bit 10~15 - OUI
> 
> Register 3 bit 4~9 - product number
> 
> Register 3 bit 0~3 - revision number
> 
> These PHYs have same ID in register 2 and 3.

O.K, that is pretty normal. Please add a phy_device for each
individual PHY. There are macros to help you do this.

	Andrew