netdev - Re: [PATCH net-next] net: lantiq: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a66836af-99a4-9bc1-3c0c-6cb9bb1cc4d9@hauke-m.de>
Date:   Sat, 5 Jun 2021 12:58:55 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next] net: lantiq: Use
 devm_platform_get_and_ioremap_resource()

On 6/5/21 11:26 AM, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   drivers/net/ethernet/lantiq_xrx200.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 36dc3e5f6218..003df49e40b1 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -456,13 +456,7 @@ static int xrx200_probe(struct platform_device *pdev)
>   	net_dev->max_mtu = XRX200_DMA_DATA_LEN;
>   
>   	/* load the memory ranges */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "failed to get resources\n");
> -		return -ENOENT;
> -	}
> -
> -	priv->pmac_reg = devm_ioremap_resource(dev, res);
> +	priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, &res);

res is not used anywhere else, you can provide NULL instead of res and 
remove the variable.

priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

>   	if (IS_ERR(priv->pmac_reg))
>   		return PTR_ERR(priv->pmac_reg);
>   
> 


Download attachment "OpenPGP_0x93DD20630910B515.asc" of type "application/pgp-keys" (9896 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (489 bytes)