netdev - Re: [PATCH net-next] net: lantiq: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a76bc60-4ce3-e8ec-10b5-56faaf65b58e@huawei.com>
Date:   Sat, 5 Jun 2021 19:55:43 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Hauke Mehrtens <hauke@...ke-m.de>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: lantiq: Use
 devm_platform_get_and_ioremap_resource()


On 2021/6/5 18:58, Hauke Mehrtens wrote:
> On 6/5/21 11:26 AM, Yang Yingliang wrote:
>> Use devm_platform_get_and_ioremap_resource() to simplify
>> code.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> ---
>>   drivers/net/ethernet/lantiq_xrx200.c | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/lantiq_xrx200.c 
>> b/drivers/net/ethernet/lantiq_xrx200.c
>> index 36dc3e5f6218..003df49e40b1 100644
>> --- a/drivers/net/ethernet/lantiq_xrx200.c
>> +++ b/drivers/net/ethernet/lantiq_xrx200.c
>> @@ -456,13 +456,7 @@ static int xrx200_probe(struct platform_device 
>> *pdev)
>>       net_dev->max_mtu = XRX200_DMA_DATA_LEN;
>>         /* load the memory ranges */
>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -    if (!res) {
>> -        dev_err(dev, "failed to get resources\n");
>> -        return -ENOENT;
>> -    }
>> -
>> -    priv->pmac_reg = devm_ioremap_resource(dev, res);
>> +    priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, 
>> &res);
>
> res is not used anywhere else, you can provide NULL instead of res and 
> remove the variable.
>
> priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
OK, thanks for your suggestion.
>
>>       if (IS_ERR(priv->pmac_reg))
>>           return PTR_ERR(priv->pmac_reg);
>>
>