netdev - RE: [PATCH RESEND iproute2-next] devlink: Add optional controller user input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR12MB54813150C3567170590BE36DDC389@PH0PR12MB5481.namprd12.prod.outlook.com>
Date:   Mon, 7 Jun 2021 15:12:36 +0000
From:   Parav Pandit <parav@...dia.com>
To:     David Ahern <dsahern@...il.com>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH RESEND iproute2-next] devlink: Add optional controller
 user input



> From: David Ahern <dsahern@...il.com>
> Sent: Monday, June 7, 2021 8:11 PM
> 
> On 6/7/21 5:43 AM, Parav Pandit wrote:
> > Hi David,
> >
> >> From: David Ahern <dsahern@...il.com>
> >> Sent: Monday, June 7, 2021 8:31 AM
> >>
> >> On 6/3/21 5:19 AM, Parav Pandit wrote:
> >>> @@ -3795,7 +3806,7 @@ static void cmd_port_help(void)
> >>>  	pr_err("       devlink port param set DEV/PORT_INDEX name
> >> PARAMETER value VALUE cmode { permanent | driverinit | runtime }\n");
> >>>  	pr_err("       devlink port param show [DEV/PORT_INDEX name
> >> PARAMETER]\n");
> >>>  	pr_err("       devlink port health show [ DEV/PORT_INDEX reporter
> >> REPORTER_NAME ]\n");
> >>> -	pr_err("       devlink port add DEV/PORT_INDEX flavour FLAVOUR
> >> pfnum PFNUM [ sfnum SFNUM ]\n");
> >>> +	pr_err("       devlink port add DEV/PORT_INDEX flavour FLAVOUR
> >> pfnum PFNUM [ sfnum SFNUM ] [ controller CNUM ]\n");
> >>>  	pr_err("       devlink port del DEV/PORT_INDEX\n");
> >>>  }
> >>>
> >>> @@ -4324,7 +4335,7 @@ static int __cmd_health_show(struct dl *dl,
> >>> bool show_device, bool show_port);
> >>>
> >>>  static void cmd_port_add_help(void)  {
> >>> -	pr_err("       devlink port add { DEV | DEV/PORT_INDEX } flavour
> >> FLAVOUR pfnum PFNUM [ sfnum SFNUM ]\n");
> >>> +	pr_err("       devlink port add { DEV | DEV/PORT_INDEX } flavour
> >> FLAVOUR pfnum PFNUM [ sfnum SFNUM ] [ controller CNUM ]\n");
> >>
> >> This line and the one above need to be wrapped. This addition puts it
> >> well into the 90s.
> >>
> > It’s a print message.
> > I was following coding style of [1] that says "However, never break user-
> visible strings such as printk messages because that breaks the ability to grep
> for them.".
> > Recent code of dcb_ets.c has similar long string in print. So I didn't wrap it.
> 
> I missed that when reviewing the dcb command then.
> 
> > Should we warp it?
> >
> > [1]
> > https://www.kernel.org/doc/html/latest/process/coding-style.html#break
> > ing-long-lines-and-strings
> >
> 
> [1] is referring to messages from kernel code, and I agree with that style. This
> is help message from iproute2. I tend to keep my terminal widths between
> 80 and 90 columns, so the long help lines from commands are not very
> friendly causing me to resize the terminal.
I see. So do you recommend splitting the print message?
I personally feel easier to follow kernel coding standard as much possible in spirit of "grep them". 😊
But its really up to you. Please let me know.