lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87h7i6n1us.fsf@toke.dk>
Date:   Wed, 09 Jun 2021 23:51:23 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Maxim Mikityanskiy <maximmi@...dia.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Patrick McHardy <kaber@...sh.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Christoph Paasch <cpaasch@...le.com>,
        Peter Krystad <peter.krystad@...ux.intel.com>
Cc:     Young Xiao <92siuyang@...il.com>, netdev@...r.kernel.org,
        Maxim Mikityanskiy <maximmi@...dia.com>
Subject: Re: [PATCH net 3/3] sch_cake: Fix out of bounds when parsing TCP
 options

Maxim Mikityanskiy <maximmi@...dia.com> writes:

> The TCP option parser in cake qdisc (cake_get_tcpopt and
> cake_tcph_may_drop) could read one byte out of bounds. When the length
> is 1, the execution flow gets into the loop, reads one byte of the
> opcode, and if the opcode is neither TCPOPT_EOL nor TCPOPT_NOP, it reads
> one more byte, which exceeds the length of 1.
>
> This fix is inspired by commit 9609dad263f8 ("ipv4: tcp_input: fix stack
> out of bounds when parsing TCP options.").
>
> Cc: Young Xiao <92siuyang@...il.com>
> Fixes: 8b7138814f29 ("sch_cake: Add optional ACK filter")
> Signed-off-by: Maxim Mikityanskiy <maximmi@...dia.com>

Thanks for fixing this!

Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ