netdev - Re: [PATCH net] qmi_wwan: Clone the skb when in pass-through mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfDRXi=4Vsf_a40EdLsyunjKGXaFnA0ZeNbMcBDw1Tk+eSzMQ@mail.gmail.com>
Date:   Mon, 14 Jun 2021 19:02:15 +0200
From:   Kristian Evensen <kristian.evensen@...il.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Network Development <netdev@...r.kernel.org>,
        subashab@...eaurora.org
Subject: Re: [PATCH net] qmi_wwan: Clone the skb when in pass-through mode

Hi Bjørn,

On Mon, Jun 14, 2021 at 5:49 PM Kristian Evensen
<kristian.evensen@...il.com> wrote:
> I will do some more testing tomorrow and see if I can figure out
> something. So far, the only thing I know is that if I try to perform a
> more demanding transfer (like downloading a file) using qmi_wwan +
> rmnet then I get a kernel oops immediatly.

I got curios and decided to test your proposed changed today.
Replacing the call to netif_rx() with return 1, and then letting
usbnet_skb_return() do the netif_rx() call, seems to have resolved the
issue. At least I am not longer able to trigger the oops using my
earlier reproducer (running a couple of Speedtest).

Unless someone beats me to it, I will prepare another patch tomorrow.
Thanks for the help.

Kristian