netdev - Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Jun 2021 10:48:07 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Jussi Maki <joamaki@...il.com>
Cc:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>, j.vosburgh@...il.com,
        Andy Gospodarek <andy@...yhouse.net>, vfalico@...il.com,
        Andrii Nakryiko <andrii@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding

On Mon, Jun 14, 2021 at 10:09 AM Jussi Maki <joamaki@...il.com> wrote:
>
> On Thu, Jun 10, 2021 at 12:19 AM Maciej Fijalkowski
> <maciej.fijalkowski@...el.com> wrote:
> >
> > On Wed, Jun 09, 2021 at 01:55:37PM +0000, Jussi Maki wrote:
> > > Add a test suite to test XDP bonding implementation
> > > over a pair of veth devices.
> >
> > Cc: Magnus
> >
> > Jussi,
> > AF_XDP selftests have very similar functionality just like you are trying
> > to introduce over here, e.g. we setup veth pair and generate traffic.
> > After a quick look seems that we could have a generic layer that would
> > be used by both AF_XDP and bonding selftests.
> >
> > WDYT?
>
> Sounds like a good idea to me to have more shared code in the
> selftests and I don't see a reason not to use the AF_XDP datapath in
> the bonding selftests. I'll look into it this week and get back to
> you.

Note, that I am currently rewriting a large part of the AF_XDP
selftests making it more amenable to adding various tests. A test is
in my patch set is described as a set of packets to send, a set of
packets that should be received in a certain order with specified
contents, and configuration/setup information for the sender and
receiver. The current code is riddled with test specific if-statements
that make it hard to extend and use generically. So please hold off
for a week or so and review my patch set when I send it to the list.
Better use of your time. Hopefully we can make it fit your bill too
with not too much work.