netdev - Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHn8xcmgeV+NBt7t9t46AK_x7oSrRvPC6QnP34BhL=VLs_q3hA@mail.gmail.com>
Date:   Mon, 14 Jun 2021 14:20:29 +0200
From:   Jussi Maki <joamaki@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>, j.vosburgh@...il.com,
        Andy Gospodarek <andy@...yhouse.net>, vfalico@...il.com,
        Andrii Nakryiko <andrii@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding

On Mon, Jun 14, 2021 at 10:48 AM Magnus Karlsson
<magnus.karlsson@...il.com> wrote:
>
> On Mon, Jun 14, 2021 at 10:09 AM Jussi Maki <joamaki@...il.com> wrote:
> > Sounds like a good idea to me to have more shared code in the
> > selftests and I don't see a reason not to use the AF_XDP datapath in
> > the bonding selftests. I'll look into it this week and get back to
> > you.
>
> Note, that I am currently rewriting a large part of the AF_XDP
> selftests making it more amenable to adding various tests. A test is
> in my patch set is described as a set of packets to send, a set of
> packets that should be received in a certain order with specified
> contents, and configuration/setup information for the sender and
> receiver. The current code is riddled with test specific if-statements
> that make it hard to extend and use generically. So please hold off
> for a week or so and review my patch set when I send it to the list.
> Better use of your time. Hopefully we can make it fit your bill too
> with not too much work.

Ok, thanks for the heads up! Looking forward to your patch set.