netdev - Re: [PATCH] cxgb4: fix wrong shift.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMh+KitE/UXqidNn@kroah.com>
Date:   Tue, 15 Jun 2021 12:17:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        Colin Ian King <colin.king@...onical.com>,
        "David S. Miller" <davem@...emloft.net>,
        Raju Rangoju <rajur@...lsio.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] cxgb4: fix wrong shift.

On Tue, Jun 15, 2021 at 11:56:51AM +0200, Pavel Machek wrote:
> While fixing coverity warning, commit
> dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
> value. Fix that.
>     
> Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> index 22c9ac922eba..6260b3bebd2b 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> @@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
>  				      WORD_MASK, f->fs.nat_lip[3] |
>  				      f->fs.nat_lip[2] << 8 |
>  				      f->fs.nat_lip[1] << 16 |
> -				      (u64)f->fs.nat_lip[0] << 25, 1);
> +				      (u64)f->fs.nat_lip[0] << 24, 1);
>  		}
>  	}
>  
> 


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>