netdev - Re: [RESEND PATCH V3 2/6] PCI: Use cached Device Capabilities 2 Register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a6ebe32-6312-32fa-b02b-a0f205334e11@huawei.com>
Date:   Tue, 15 Jun 2021 11:04:35 +0800
From:   Dongdong Liu <liudongdong3@...wei.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     <helgaas@...nel.org>, <kw@...ux.com>, <linux-pci@...r.kernel.org>,
        <rajur@...lsio.com>, <hverkuil-cisco@...all.nl>,
        <linux-media@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [RESEND PATCH V3 2/6] PCI: Use cached Device Capabilities 2
 Register

On 2021/6/14 13:49, Christoph Hellwig wrote:
>> +			if (!(bridge->pcie_devcap2 & PCI_EXP_DEVCAP2_ATOMIC_ROUTE))
>
> Overly long line.
>
Will fix.
>> +static void pci_init_devcap2(struct pci_dev *dev)
>> +{
>> +	if (!pci_is_pcie(dev))
>> +		return;
>> +
>> +	pcie_capability_read_dword(dev, PCI_EXP_DEVCAP2, &dev->pcie_devcap2);
>> +}
>
> Wouldn't it make sene to merge this into set_pcie_port_type?
Good suggestion, will do.

Thanks,
Dongdong
> .
>