netdev - Re: [PATCH iproute2] uapi: add missing virtio related headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jun 2021 09:13:27 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Parav Pandit <parav@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] uapi: add missing virtio related headers

On Mon, Jun 14, 2021 at 07:03:36PM -0600, David Ahern wrote:
> On 6/11/21 10:21 AM, Stephen Hemminger wrote:
> > On Thu, 10 Jun 2021 20:54:45 -0600
> > David Ahern <dsahern@...il.com> wrote:
> > 
> >> On 6/8/21 11:15 PM, Parav Pandit wrote:
> >>> Hi Stephen,
> >>>
> >>> vdpa headers were present in commit c2ecc82b9d4c at [1].
> >>>
> >>> I added them at [1] after David's recommendation in [2].
> >>>
> >>> Should we remove [1]?
> >>> Did you face compilation problem without this fix?
> >>>
> >>> [1] ./vdpa/include/uapi/linux/vdpa.h
> >>> [2] https://lore.kernel.org/netdev/abc71731-012e-eaa4-0274-5347fc99c249@gmail.com/
> >>>
> >>> Parav  
> >>
> >> Stephen: Did you hit a compile issue? vdpa goes beyond networking and
> >> features go through other trees AIUI so the decision was to put the uapi
> >> file under the vdpa command similar to what rdma is doing.
> >>
> > 
> > In iproute2, all kernel headers used during the build should come from include/uapi.
> > If new command or function needs a new header, then the sanitized version should be
> > included.
> > 
> > I update these with an automated script, and making special case for vdpa
> > seems to be needless effort. Please just let iproute's include/uapi just be
> > a copy of what kernel "make install_headers" generates.
> > 
> 
> an exception was made for rdma because of the order in which uapi
> updates hit the net-next tree. The same exception was being made for
> vdpa for the same reason.

Right, and almost all RDMA features are accompanied by the commit like
this which brings headers cycle earlier than they will appear in net-next.

commit 212e2c1d0cb27f0d1f87b9cc6454b8afbeb2d467
Author: Gal Pressman <galpress@...zon.com>
Date:   Thu Apr 29 09:48:02 2021 +0300

    rdma: update uapi headers

    Update rdma_netlink.h file upto kernel commit
    6cc9e215eb27 ("RDMA/nldev: Add copy-on-fork attribute to get sys command")

    Signed-off-by: Gal Pressman <galpress@...zon.com>
    Acked-by: Leon Romanovsky <leonro@...dia.com>
    Signed-off-by: David Ahern <dsahern@...nel.org>