netdev - Re: [PATCH iproute2] uapi: add missing virtio related headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78f32159-24d7-0ea6-6be3-add0186b97c2@gmail.com>
Date:   Mon, 14 Jun 2021 19:03:36 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Parav Pandit <parav@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] uapi: add missing virtio related headers

On 6/11/21 10:21 AM, Stephen Hemminger wrote:
> On Thu, 10 Jun 2021 20:54:45 -0600
> David Ahern <dsahern@...il.com> wrote:
> 
>> On 6/8/21 11:15 PM, Parav Pandit wrote:
>>> Hi Stephen,
>>>
>>> vdpa headers were present in commit c2ecc82b9d4c at [1].
>>>
>>> I added them at [1] after David's recommendation in [2].
>>>
>>> Should we remove [1]?
>>> Did you face compilation problem without this fix?
>>>
>>> [1] ./vdpa/include/uapi/linux/vdpa.h
>>> [2] https://lore.kernel.org/netdev/abc71731-012e-eaa4-0274-5347fc99c249@gmail.com/
>>>
>>> Parav  
>>
>> Stephen: Did you hit a compile issue? vdpa goes beyond networking and
>> features go through other trees AIUI so the decision was to put the uapi
>> file under the vdpa command similar to what rdma is doing.
>>
> 
> In iproute2, all kernel headers used during the build should come from include/uapi.
> If new command or function needs a new header, then the sanitized version should be
> included.
> 
> I update these with an automated script, and making special case for vdpa
> seems to be needless effort. Please just let iproute's include/uapi just be
> a copy of what kernel "make install_headers" generates.
> 

an exception was made for rdma because of the order in which uapi
updates hit the net-next tree. The same exception was being made for
vdpa for the same reason.