netdev - Re: [RFC 2/3] [RFC iproute2-next] tc: f_u32: Fix the ipv6 pretty printing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210614195700.260c8933@hermes.local>
Date:   Mon, 14 Jun 2021 19:57:00 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Anton Danilov <littlesmilingcloud@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC 2/3] [RFC iproute2-next] tc: f_u32: Fix the ipv6 pretty
 printing.

On Tue,  8 Jun 2021 18:33:08 +0300
Anton Danilov <littlesmilingcloud@...il.com> wrote:

> -			fprintf(f, "\n  match IP protocol %d",
> +			return fprintf(f, "\n  match IP protocol %d",
>  				ntohl(key->val) >> 16);

Ok, but better yet, upgrade f_u32 to do proper JSON output.

> +			// The ipv6 pretty printing requires an additional call at the end.
> +			// Call the show_keys with the NULL value after call with last key.
> +			for (i = 0; i <= sel->nkeys; i++) {

iproute2 uses kernel style C so no C++ style comments please