netdev - Re: [PATCH net-next 6/8] net: phy: print the function name by __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a4d88aaf8a8483b8a4514c4c414457f@huawei.com>
Date:   Tue, 15 Jun 2021 06:26:06 +0000
From:   liweihang <liweihang@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        liangwenpeng <liangwenpeng@...wei.com>
Subject: Re: [PATCH net-next 6/8] net: phy: print the function name by
 __func__ instead of an fixed string

On 2021/6/12 0:05, Andrew Lunn wrote:
> On Fri, Jun 11, 2021 at 02:36:57PM +0800, Weihang Li wrote:
>> From: Wenpeng Liang <liangwenpeng@...wei.com>
>>
>> It's better to use __func__ than a fixed string to print a
>> function's name.
>>
>> Signed-off-by: Wenpeng Liang <liangwenpeng@...wei.com>
>> Signed-off-by: Weihang Li <liweihang@...wei.com>
>> ---
>>  drivers/net/phy/mdio_device.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c
>> index 0837319..c94cb53 100644
>> --- a/drivers/net/phy/mdio_device.c
>> +++ b/drivers/net/phy/mdio_device.c
>> @@ -77,7 +77,7 @@ int mdio_device_register(struct mdio_device *mdiodev)
>>  {
>>  	int err;
>>  
>> -	dev_dbg(&mdiodev->dev, "mdio_device_register\n");
>> +	dev_dbg(&mdiodev->dev, "%s\n", __func__);
>>  
>>  	err = mdiobus_register_device(mdiodev);
>>  	if (err)
>> @@ -188,7 +188,7 @@ int mdio_driver_register(struct mdio_driver *drv)
>>  	struct mdio_driver_common *mdiodrv = &drv->mdiodrv;
>>  	int retval;
>>  
>> -	pr_debug("mdio_driver_register: %s\n", mdiodrv->driver.name);
>> +	pr_debug("%s: %s\n", __func__, mdiodrv->driver.name);
> 
> It would be nice to make this
> 
>         dev_dbg(&mdiodev->dev, "%s: %s\n", __func__, mdiodrv->driver.name);
> 
> 	Andrew
> 

Thanks for the advice, I will change it.

Weihang