netdev - Re: [PATCH net-next 7/8] net: phy: remove unnecessary line continuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3315ce40e68e4d55ab56e365d2d724a9@huawei.com>
Date:   Tue, 15 Jun 2021 06:26:31 +0000
From:   liweihang <liweihang@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        liangwenpeng <liangwenpeng@...wei.com>
Subject: Re: [PATCH net-next 7/8] net: phy: remove unnecessary line
 continuation

On 2021/6/12 0:07, Andrew Lunn wrote:
>> -			phy_write(phydev, ET1011C_CONFIG_REG, val\
>> -					| ET1011C_GMII_INTERFACE\
>> -					| ET1011C_SYS_CLK_EN\
>> +			phy_write(phydev, ET1011C_CONFIG_REG, val
>> +					| ET1011C_GMII_INTERFACE
>> +					| ET1011C_SYS_CLK_EN
>>  					| ET1011C_TX_FIFO_DEPTH_16);
> 
> Please put the | at the end of the line, not the beginning of the next
> line.
> 
> Thanks
> 	Andrew
> 

Sure, thank you.

Weihang