netdev - Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Jun 2021 12:52:46 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     brouer@...hat.com, <davem@...emloft.net>, <kuba@...nel.org>,
        <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>,
        <john.fastabend@...il.com>, <andrii@...nel.org>, <kafai@...com>,
        <songliubraving@...com>, <yhs@...com>, <kpsingh@...nel.org>,
        <bpf@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd
 usage

On Tue, 15 Jun 2021 21:55:54 +0800
Wang Hai <wanghai38@...wei.com> wrote:

> xdp_fwd usage() is missing the introduction of the "-S"
> and "-F" options, this patch adds it.
> 
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  samples/bpf/xdp_fwd_user.c | 2 ++
>  1 file changed, 2 insertions(+)


Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")

LGTM but please add "Fixes:" tag next time, I think patchwork will pick
this up via this reply.

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>


> diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c
> index 74a4583d0d86..00061261a8da 100644
> --- a/samples/bpf/xdp_fwd_user.c
> +++ b/samples/bpf/xdp_fwd_user.c
> @@ -67,6 +67,8 @@ static void usage(const char *prog)
>  		"usage: %s [OPTS] interface-list\n"
>  		"\nOPTS:\n"
>  		"    -d    detach program\n"
> +		"    -S    use skb-mode\n"
> +		"    -F    force loading prog\n"
>  		"    -D    direct table lookups (skip fib rules)\n",
>  		prog);
>  }
    -


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer