netdev - Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210616125550.2f0e2544@carbon>
Date:   Wed, 16 Jun 2021 12:55:50 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     brouer@...hat.com, <davem@...emloft.net>, <kuba@...nel.org>,
        <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>,
        <john.fastabend@...il.com>, <andrii@...nel.org>, <kafai@...com>,
        <songliubraving@...com>, <yhs@...com>, <kpsingh@...nel.org>,
        <bpf@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] samples/bpf: Add missing option to
 xdp_sample_pkts usage

On Tue, 15 Jun 2021 21:57:24 +0800
Wang Hai <wanghai38@...wei.com> wrote:

> xdp_sample_pkts usage() is missing the introduction of the
> "-S" option, this patch adds it.
> 
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  samples/bpf/xdp_sample_pkts_user.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
 
> diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
> index 706475e004cb..495e09897bd3 100644
> --- a/samples/bpf/xdp_sample_pkts_user.c
> +++ b/samples/bpf/xdp_sample_pkts_user.c
> @@ -103,7 +103,8 @@ static void usage(const char *prog)
>  	fprintf(stderr,
>  		"%s: %s [OPTS] <ifname|ifindex>\n\n"
>  		"OPTS:\n"
> -		"    -F    force loading prog\n",
> +		"    -F    force loading prog\n"
> +		"    -S    use skb-mode\n",
>  		__func__, prog);
>  }
>  

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer