netdev - Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMt4ZMuPfjeesnRK@lunn.ch>
Date:   Thu, 17 Jun 2021 18:29:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Peng Li <lipeng321@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, xie.he.0141@...il.com,
        ms@....tdt.de, willemb@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, huangguangbin2@...wei.com
Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style
 issue

> @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d)
>  static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd)
>  {
>  	/* struct z8530_dev *sv11=dev_to_sv(d);
> -	   z8530_ioctl(d,&sv11->chanA,ifr,cmd) */
> +	 * z8530_ioctl(d,&sv11->chanA,ifr,cmd)
> +	 */
>  	return hdlc_ioctl(d, ifr, cmd);
>  }

That looks more like dead code than anything else. I would suggest you
do a git blame to see if there is anything interesting about this, and
if not, remove it.

   Andrew