netdev - Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ea3967f-b4e4-323b-bf65-aac108c6d27f@huawei.com>
Date:   Fri, 18 Jun 2021 08:45:22 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <xie.he.0141@...il.com>,
        <ms@....tdt.de>, <willemb@...gle.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <huangguangbin2@...wei.com>
Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style
 issue


在 2021/6/18 0:29, Andrew Lunn 写道:
>> @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d)
>>   static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd)
>>   {
>>   	/* struct z8530_dev *sv11=dev_to_sv(d);
>> -	   z8530_ioctl(d,&sv11->chanA,ifr,cmd) */
>> +	 * z8530_ioctl(d,&sv11->chanA,ifr,cmd)
>> +	 */
>>   	return hdlc_ioctl(d, ifr, cmd);
>>   }
> That looks more like dead code than anything else. I would suggest you
> do a git blame to see if there is anything interesting about this, and
> if not, remove it.
>
>     Andrew
> .

Hi,  Andrew

It's  dead code,  will remove it.

Thanks for your advice.

         Peng Li