netdev - Re: [PATCH bpf-next v2 03/16] xdp: add proper __rcu annotations to redirect map entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210617194155.rkfyv2ixgshuknt6@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 17 Jun 2021 12:41:55 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
CC:     <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        Hangbin Liu <liuhangbin@...il.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH bpf-next v2 03/16] xdp: add proper __rcu annotations to
 redirect map entries

On Tue, Jun 15, 2021 at 04:54:42PM +0200, Toke Høiland-Jørgensen wrote:
[ ... ]

>  static void *__dev_map_hash_lookup_elem(struct bpf_map *map, u32 key)
>  {
>  	struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
> @@ -266,7 +270,8 @@ static void *__dev_map_hash_lookup_elem(struct bpf_map *map, u32 key)
>  	struct bpf_dtab_netdev *dev;
>  
>  	hlist_for_each_entry_rcu(dev, head, index_hlist,
> -				 lockdep_is_held(&dtab->index_lock))
> +				 (lockdep_is_held(&dtab->index_lock) ||
> +				  rcu_read_lock_bh_held()))
This change is not needed also.

Others lgtm.