netdev - Re: [PATCH bpf-next v2 03/16] xdp: add proper __rcu annotations to redirect map entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87czskdwj6.fsf@toke.dk>
Date:   Thu, 17 Jun 2021 23:13:49 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Hangbin Liu <liuhangbin@...il.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH bpf-next v2 03/16] xdp: add proper __rcu annotations to
 redirect map entries

Martin KaFai Lau <kafai@...com> writes:

> On Tue, Jun 15, 2021 at 04:54:42PM +0200, Toke Høiland-Jørgensen wrote:
> [ ... ]
>
>>  static void *__dev_map_hash_lookup_elem(struct bpf_map *map, u32 key)
>>  {
>>  	struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
>> @@ -266,7 +270,8 @@ static void *__dev_map_hash_lookup_elem(struct bpf_map *map, u32 key)
>>  	struct bpf_dtab_netdev *dev;
>>  
>>  	hlist_for_each_entry_rcu(dev, head, index_hlist,
>> -				 lockdep_is_held(&dtab->index_lock))
>> +				 (lockdep_is_held(&dtab->index_lock) ||
>> +				  rcu_read_lock_bh_held()))
> This change is not needed also.

Ah yes, of course - my bad for forgetting to remove that as well. Will
send a v3!

-Toke