netdev - Re: [PATCH] net: hns3: Fix a memory leak in an error handling path in 'hclge_handle_error_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jun 2021 20:41:45 +0800
From:   zhangjiaran <zhangjiaran@...wei.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <huangguangbin2@...wei.com>, <tanhuazhong@...wei.com>,
        <moyufeng@...wei.com>, <lipeng321@...wei.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] net: hns3: Fix a memory leak in an error handling path in
 'hclge_handle_error_info_log()'



在 2021/6/20 17:49, Christophe JAILLET 写道:
> If this 'kzalloc()' fails we must free some resources as in all the other
> error handling paths of this function.
> 
> Fixes: 2e2deee7618b ("net: hns3: add the RAS compatibility adaptation solution")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
> index bad9fda19398..ec9a7f8bc3fe 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
> @@ -2330,8 +2330,10 @@ int hclge_handle_error_info_log(struct hnae3_ae_dev *ae_dev)
>  	buf_size = buf_len / sizeof(u32);
>  
>  	desc_data = kzalloc(buf_len, GFP_KERNEL);
> -	if (!desc_data)
> -		return -ENOMEM;
> +	if (!desc_data) {
> +		ret = -ENOMEM;
> +		goto err_desc;
> +	}
>  
>  	buf = kzalloc(buf_len, GFP_KERNEL);
>  	if (!buf) {
> 

Reviewed-by: Jiaran Zhang <zhangjiaran@...wei.com>