netdev - Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNCKsPiIQP/ov39V@lunn.ch>
Date:   Mon, 21 Jun 2021 14:48:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Liang Xu <lxu@...linear.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Thomas Mohren <tmohren@...linear.com>
Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

On Mon, Jun 21, 2021 at 05:05:06AM +0000, Liang Xu wrote:
> On 21/6/2021 10:30 am, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> > On Fri, Jun 18, 2021 at 03:36:35PM +0000, Liang Xu wrote:
> >> On 18/6/2021 10:01 pm, Andrew Lunn wrote:
> >>> This email was sent from outside of MaxLinear.
> >>>
> >>>
> >>>> Net-next:
> >>>>
> >>>> int genphy_loopback(struct phy_device *phydev, bool enable)
> >>>> {
> >>>>        if (enable) {
> >>>>            u16 val, ctl = BMCR_LOOPBACK;
> >>>>            int ret;
> >>>>
> >>>>            if (phydev->speed == SPEED_1000)
> >>>>                ctl |= BMCR_SPEED1000;
> >>>>            else if (phydev->speed == SPEED_100)
> >>>>                ctl |= BMCR_SPEED100;
> >> The problem happens in the speed change no matter it's forced or
> >> auto-neg in our device.
> > You say speed change. So do you just need to add support for 10Mbps,
> > so there is no speed change? Or are you saying phydev->speed does not
> > match the actual speed?
> >
> >        Andrew
> >
> We have 2.5G link speed, so mismatch happens.

Ah, yes.  Sorry.

Please implement it in your driver.

       Andrew