netdev - Re: [PATCH net-next] Revert "net/sched: cls_flower: Remove match on n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210621101114.26hvcfhsbsagkzru@skbuf>
Date:   Mon, 21 Jun 2021 13:11:14 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Boris Sukholitko <boris.sukholitko@...adcom.com>
Cc:     netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        Ilya Lifshits <ilya.lifshits@...adcom.com>
Subject: Re: [PATCH net-next] Revert "net/sched: cls_flower: Remove match on
 n_proto"

On Mon, Jun 21, 2021 at 12:24:29PM +0300, Boris Sukholitko wrote:
> This reverts commit 0dca2c7404a938cb10c85d0515cee40ed5348788.
> 
> The commit in question breaks hardware offload of flower filters.
> 
> Quoting Vladimir Oltean <olteanv@...il.com>:
> 
>  fl_hw_replace_filter() and fl_reoffload() create a struct
>  flow_cls_offload with a rule->match.mask member derived from the mask
>  of the software classifier: &f->mask->key - that same mask that is used
>  for initializing the flow dissector keys, and the one from which Boris
>  removed the basic.n_proto member because it was bothering him.
> 
> Reported-by: Vadym Kochan <vadym.kochan@...ision.eu>
> Signed-off-by: Boris Sukholitko <boris.sukholitko@...adcom.com>
> ---

Perhaps not the most relevant crop from the quote, but anyway:

Reviewed-by: Vladimir Oltean <olteanv@...il.com>