netdev - Re: [EXT] Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth profiles config support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR18MB46661477EC162BF123B79FE0A10A9@CO1PR18MB4666.namprd18.prod.outlook.com>
Date:   Mon, 21 Jun 2021 10:19:10 +0000
From:   Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To:     Kees Cook <keescook@...omium.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>
Subject: Re: [EXT] Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth
 profiles config support

Hi Kees Cook,

Thanks. I will send the fix to net.

Sundeep

________________________________________
From: Kees Cook <keescook@...omium.org>
Sent: Friday, June 18, 2021 9:37 PM
To: Subbaraya Sundeep Bhatta
Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org; Sunil Kovvuri Goutham; Hariprasad Kelam; Geethasowjanya Akula
Subject: [EXT] Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth profiles config support

External Email

----------------------------------------------------------------------
On Tue, Jun 15, 2021 at 05:04:27PM +0530, Subbaraya Sundeep wrote:
> [...]
> @@ -885,6 +906,9 @@ static int rvu_nix_blk_aq_enq_inst(struct rvu *rvu, struct nix_hw *nix_hw,
>                       else if (req->ctype == NIX_AQ_CTYPE_MCE)
>                               memcpy(&rsp->mce, ctx,
>                                      sizeof(struct nix_rx_mce_s));
> +                     else if (req->ctype == NIX_AQ_CTYPE_BANDPROF)
> +                             memcpy(&rsp->prof, ctx,
> +                                    sizeof(struct nix_bandprof_s));

rsp->prof is u64 not struct nix_bandprof_s, so the compiler thinks this
memcpy() is overflowing the "prof" field.

Can you please fix this up?

--
Kees Cook