netdev - Re: Realtek 8139 problem on 486.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0Z56XvLHJHjvsX3F76ZF0n-VXwPoWbvfQdTgfEBfOneg@mail.gmail.com>
Date:   Mon, 21 Jun 2021 13:22:34 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Nikolai Zhubr <zhubr.2@...il.com>,
        netdev <netdev@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: Realtek 8139 problem on 486.

On Mon, Jun 21, 2021 at 6:10 AM Maciej W. Rozycki <macro@...am.me.uk> wrote:
> On Sun, 20 Jun 2021, Thomas Gleixner wrote:
>
> > Alternatively we can just emit a noisy warning when a legacy PCI
> > interrupt is configured as edge by the BIOS and tell people to toggle
> > that switch if stuff does not work. Though that might be futile because
> > not all BIOSes have these toggle options.
>
>  A warning surely won't hurt, but TBH I'd just reprogram any incorrectly
> configured PCI interrupt line unconditionally where the ELCR is available.
> The chance someone uses a broken PCI card that drives its interrupt line
> as edge-triggered and is actually handled by a Linux driver both at a time
> is IMO nil.  Such a card requires special provisions hardly any system
> provides and has anyone here seen a report of such a beast?

I looked some more through the git history and found at least one time
that the per-chipset ELCR fixup came up for discussion[1], and this
appears to have resulted in generalizing an ALI specific fixup into
common code into common code[2], so we should already be doing
exactly this in many cases. If Nikolai can boot the system with debugging
enabled for arch/x86/pci/irq.c, we should be able to see exactly
which code path is his in his case, and why it doesn't go through
setting that register at the moment.

I also found an slightly more recent discussion, from where it seems
that the authoritative decision when it came up in the past was that edge
triggered interrupts are supposed to work as long as they are not
shared [3][4].

       Arnd

[1] https://lore.kernel.org/lkml/Pine.LNX.4.10.10011230901580.7992-100000@penguin.transmeta.com/
[2] https://repo.or.cz/davej-history.git/commitdiff/e3576079d9e2#patch63
[3] https://yarchive.net/comp/linux/edge_triggered_interrupts.html
[4] https://lore.kernel.org/lkml/Pine.LNX.4.64.0604241156340.3701@g5.osdl.org/