netdev - Re: [PATCH net-next] ipv6: ICMPV6: add response to ICMPV6 RFC 8335 PROBE messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c2b20f7-9892-cc47-035f-29b9d0b2b741@gmail.com>
Date:   Thu, 24 Jun 2021 08:32:37 -0600
From:   David Ahern <dsahern@...il.com>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org
Subject: Re: [PATCH net-next] ipv6: ICMPV6: add response to ICMPV6 RFC 8335
 PROBE messages

On 6/24/21 6:51 AM, Andreas Roeseler wrote:
> It is copied because I was under the impression that it is generally
> good practice to keep the IPv4 and IPv6 code separate since they can be
> compiled modularly and exist independantly. If this isn't the case,
> where would be the best place to put a separate function to be called by
> both handlers? net/ipv4/icmp.c?


We want the code as common (the same) as much as possible. IPv6 can
leverage exported functions from IPv4.