netdev - Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKfcHZ642S1SczFNMruq64H9E6x0KD5+bYWHcs3uu058cQ@mail.gmail.com>
Date:   Tue, 29 Jun 2021 01:01:30 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Kurt Cancemi <kurt@...architecture.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain
 RGMII interface

Hi Kurt,


wt., 29 cze 2021 o 00:50 Marek Behún <kabel@...nel.org> napisał(a):
>
> On Mon, 28 Jun 2021 15:28:26 -0400
> Kurt Cancemi <kurt@...architecture.com> wrote:
>
> > This patch changes the default behavior to enable RX and TX delays for
> > the PHY_INTERFACE_MODE_RGMII case by default.
>
> And why would we want that? I was under the impression that we have the
> _ID variants for enabling these delays.
>

+1

>From Documentation/devicetree/bindings/net/ethernet-controller.yaml

      # RGMII with internal RX and TX delays provided by the PHY,
      # the MAC should not add the RX or TX delays in this case
      - rgmii-id

I guess you should rather fix the hardware description of your board,
i.e. use `phy-mode = "rgmii-id"` instead of tweaking the PHY driver
itself.

Best regards,
Marcin