netdev - Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADujJWW=QbsRcrvF+7UxWZssMJ0iK1+xq+mfCTAVb7SkKKXcaA@mail.gmail.com>
Date:   Mon, 28 Jun 2021 20:05:19 -0400
From:   Kurt Cancemi <kurt@...architecture.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain
 RGMII interface

Well I'm sorry for the noise I was running into a lot of other DPAA
ethernet related issues and overlooked adding phy-mode = "rgmii-id";
that fixed the issue. I knew my patch was not correct (as I explained
in the cover email) but I was not sure why it was necessary but now I
see it was not necessary I just had "phy-connection-mode" instead of
"phy-mode".

May I ask what is the purpose of phy-connection-mode? And why did the
DPAA driver recognize the PHY interface mode as RGMII ID but the
Marvell PHY driver didn't?

On Mon, Jun 28, 2021 at 7:01 PM Marcin Wojtas <mw@...ihalf.com> wrote:
>
> Hi Kurt,
>
>
> wt., 29 cze 2021 o 00:50 Marek Behún <kabel@...nel.org> napisał(a):
> >
> > On Mon, 28 Jun 2021 15:28:26 -0400
> > Kurt Cancemi <kurt@...architecture.com> wrote:
> >
> > > This patch changes the default behavior to enable RX and TX delays for
> > > the PHY_INTERFACE_MODE_RGMII case by default.
> >
> > And why would we want that? I was under the impression that we have the
> > _ID variants for enabling these delays.
> >
>
> +1
>
> From Documentation/devicetree/bindings/net/ethernet-controller.yaml
>
>       # RGMII with internal RX and TX delays provided by the PHY,
>       # the MAC should not add the RX or TX delays in this case
>       - rgmii-id
>
> I guess you should rather fix the hardware description of your board,
> i.e. use `phy-mode = "rgmii-id"` instead of tweaking the PHY driver
> itself.
>
> Best regards,
> Marcin