netdev - Re: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi9bqTB8+=xAsx3C6yAJdf3CHx9Z0AUxZpFQ-FFU5q84cQ@mail.gmail.com>
Date:   Tue, 29 Jun 2021 16:14:05 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     "Kumar, M Chetan" <m.chetan.kumar@...el.com>
Cc:     Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linuxwwan <linuxwwan@...el.com>
Subject: Re: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

Hi Chetan,

On Sun, 20 Jun 2021 at 17:42, Kumar, M Chetan <m.chetan.kumar@...el.com> wrote:
>
> Hi Sergey,
>
> > On Tue, Jun 15, 2021 at 3:30 AM Sergey Ryazanov
> > <ryazanov.s.a@...il.com> wrote:
> > > Since the last commit, the WWAN core will remove all our network
> > > interfaces for us at the time of the WWAN netdev ops unregistering.
> > > Therefore, we can safely drop the custom code that cleaning the list
> > > of created netdevs. Anyway it no longer removes any netdev, since all
> > > netdevs were removed earlier in the wwan_unregister_ops() call.
> >
> > Are you Ok with this change? I plan to submit a next version of the series. If
> > you have any objections, I can address them in V2.
>
> Changes looks fine.
>
> > BTW, if IOSM modems have a default data channel, I can add a separate
> > patch to the series to create a default network interface for IOSM if you tell
> > me which link id is used for the default data channel.
>
> Link id 1 is always associated as default data channel.

Quick question, Isn't your driver use MBIM session IDs? with
session-ID 0 as the default one?

Regards,
Loic