netdev - Re: [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register dump via ethtool -d on Topaz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNzPsaqy7CbtBjwF@lunn.ch>
Date:   Wed, 30 Jun 2021 22:10:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Vivien Didelot <vivien.didelot@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net 6/6] net: dsa: mv88e6xxx: enable SerDes PCS register
 dump via ethtool -d on Topaz

On Wed, Jun 30, 2021 at 07:43:08PM +0200, Marek Behún wrote:
> Commit bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS
> registers to ethtool -d") added support for dumping SerDes PCS registers
> via ethtool -d for Peridot.
> 
> The same implementation is also valid for Topaz, but was not
> enabled at the time.
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> Fixes: bf3504cea7d7e ("net: dsa: mv88e6xxx: Add 6390 family PCS registers to ethtool -d")

Reviewed-by: Andrew Lunn <andrew@...n.ch>

I actually think devlink regions will be better for this. But the
ethtool code exists.

    Andrew