netdev - Re: [PATCH net 1/2] selftests: icmp_redirect: remove from checking for IPv6 route get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 08:49:45 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net 1/2] selftests: icmp_redirect: remove from checking
 for IPv6 route get

On 7/7/21 2:15 AM, Hangbin Liu wrote:
> If the kernel doesn't enable option CONFIG_IPV6_SUBTREES, the RTA_SRC
> info will not be exported to userspace in rt6_fill_node(). And ip cmd will
> not print "from ::" to the route output. So remove this check.
> 
> Fixes: ec8105352869 ("selftests: Add redirect tests")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/icmp_redirect.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/icmp_redirect.sh b/tools/testing/selftests/net/icmp_redirect.sh
> index c19ecc6a8614..3a111ac1edc3 100755
> --- a/tools/testing/selftests/net/icmp_redirect.sh
> +++ b/tools/testing/selftests/net/icmp_redirect.sh
> @@ -315,7 +315,7 @@ check_exception()
>  
>  	if [ "$with_redirect" = "yes" ]; then
>  		ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
> -		grep -q "${H2_N2_IP6} from :: via ${R2_LLADDR} dev br0.*${mtu}"
> +		grep -q "${H2_N2_IP6} .*via ${R2_LLADDR} dev br0.*${mtu}"
>  	elif [ -n "${mtu}" ]; then
>  		ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
>  		grep -q "${mtu}"
> 

Reviewed-by: David Ahern <dsahern@...nel.org>