netdev - Re: [PATCH net 2/2] selftests: icmp_redirect: IPv6 PMTU info should be cleared after redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 08:51:22 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net 2/2] selftests: icmp_redirect: IPv6 PMTU info should
 be cleared after redirect

On 7/7/21 2:15 AM, Hangbin Liu wrote:
> After redirecting, it's already a new path. So the old PMTU info should
> be cleared. The IPv6 test "mtu exception plus redirect" should only
> has redirect info without old PMTU.
> 
> The IPv4 test can not be changed because of legacy.
> 
> Fixes: ec8105352869 ("selftests: Add redirect tests")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/icmp_redirect.sh | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/icmp_redirect.sh b/tools/testing/selftests/net/icmp_redirect.sh
> index 3a111ac1edc3..ecbf57f264ed 100755
> --- a/tools/testing/selftests/net/icmp_redirect.sh
> +++ b/tools/testing/selftests/net/icmp_redirect.sh
> @@ -313,9 +313,10 @@ check_exception()
>  	fi
>  	log_test $? 0 "IPv4: ${desc}"
>  
> -	if [ "$with_redirect" = "yes" ]; then
> +	# No PMTU info for test "redirect" and "mtu exception plus redirect"
> +	if [ "$with_redirect" = "yes" ] && [ "$desc" != "redirect exception plus mtu" ]; then
>  		ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
> -		grep -q "${H2_N2_IP6} .*via ${R2_LLADDR} dev br0.*${mtu}"
> +		grep -v "mtu" | grep -q "${H2_N2_IP6} .*via ${R2_LLADDR} dev br0"
>  	elif [ -n "${mtu}" ]; then
>  		ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
>  		grep -q "${mtu}"
> 

Reviewed-by: David Ahern <dsahern@...nel.org>