netdev - Re: [PATCH net] i40e: introduce pseudo number of cpus for compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03b846e9906d27ef7a6e84196a0840fdd54ca13d.camel@intel.com>
Date:   Wed, 14 Jul 2021 20:52:32 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kerneljasonxing@...il.com" <kerneljasonxing@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "kafai@...com" <kafai@...com>, "hawk@...nel.org" <hawk@...nel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "ast@...nel.org" <ast@...nel.org>,
        "kuba@...nel.org" <kuba@...nel.org>, "yhs@...com" <yhs@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>
CC:     "xingwanli@...ishou.com" <xingwanli@...ishou.com>,
        "lishujin@...ishou.com" <lishujin@...ishou.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] i40e: introduce pseudo number of cpus for
 compatibility

On Fri, 2021-07-09 at 15:13 +0800, Jason Xing wrote:
> Oh, one more thing I missed in the last email is that all the
> failures
> are happening on the combination of X722 10GbE and 1GbE. So the value
> of @num_tx_qp  the driver fetches is 384 while the value is 768
> without x722 1GbE.
> 
> I get that information back here:
> $ lspci | grep -i ether
> 5a:00.0 Ethernet controller: Intel Corporation Ethernet Connection
> X722 for 10GbE SFP+ (rev 09)
> 5a:00.1 Ethernet controller: Intel Corporation Ethernet Connection
> X722 for 10GbE SFP+ (rev 09)
> 5a:00.2 Ethernet controller: Intel Corporation Ethernet Connection
> X722 for 1GbE (rev 09)
> 5a:00.3 Ethernet controller: Intel Corporation Ethernet Connection
> X722 for 1GbE (rev 09)
> 
> I know it's really stupid to control the number of online cpus, but
> finding a good way only to limit the @alloc_queue_pairs is not easy
> to
> go. So could someone point out a better way to fix this issue and
> take
> care of some relatively old nics with the number of cpus increasing?

Hi Jason,

Sorry for the slow response; I was trying to talk to the i40e team
about this.

I agree, the limiting of number of online CPUs doesn't seem like a
solution we want to pursue. The team is working on a patch that deals
with the same, or similiar, issue; it is reworking the allocations of
the queue pile. I'll make sure that they add you on the patch when it
is sent so that you can try this and see if it resolves your issue.

Thanks,
Tony