netdev - RE: [PATCH net-next RFC] devlink: add commands to query flash and reload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51a6e7a33c7d40889c80bf37159f210e@intel.com>
Date:   Wed, 14 Jul 2021 20:54:56 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kubakici@...pl>, Jiri Pirko <jiri@...nulli.us>
Subject: RE: [PATCH net-next RFC] devlink: add commands to query flash and
 reload support



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, July 14, 2021 1:26 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: netdev@...r.kernel.org; Jakub Kicinski <kubakici@...pl>; Jiri Pirko
> <jiri@...nulli.us>
> Subject: Re: [PATCH net-next RFC] devlink: add commands to query flash and
> reload support
> 
> > I'm not sure if this is the best direction to go for implementing this.
> 
> Hi Jacob
> 
> Maybe add a --dry-run option? That would allow the driver to also read
> the firmware file, make sure it can parse it, it fits the actual
> hardware, and the CRC is O.K, etc.
> 
> We just need to make sure that if it fails with -EOPNOTSUPP, is it
> clear if --dry-run itself is not supported, or the operation is not
> supported. extack should help with that.
> 
> 	   Andrew

That approach could be useful. It doesn't give an easy way to dump all of the supported flags, but that's not super critical. I think a dry-run makes a lot of sense for flash update.

I can go that approach for these two and see how it turns out.

Thanks,
Jake