netdev - Re: [PATCH v2] net: ipv6: remove unused local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20986885-73a5-8e58-0eb9-54b0723467e4@gmail.com>
Date:   Thu, 15 Jul 2021 08:16:28 -0600
From:   David Ahern <dsahern@...il.com>
To:     Rocco Yue <rocco.yue@...iatek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, rocco.yue@...il.com
Subject: Re: [PATCH v2] net: ipv6: remove unused local variable

On 7/14/21 10:20 PM, Rocco Yue wrote:
> The local variable "struct net *net" in the two functions of
> inet6_rtm_getaddr() and inet6_dump_addr() are actually useless,
> so remove them.
> 
> Signed-off-by: Rocco Yue <rocco.yue@...iatek.com>
> ---
>  net/ipv6/addrconf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

a v2 with no changelog. From what I can tell the only difference is
"net: " in the Subject line which is not what I said in the last email.

Let me try again: There are 2 trees - net for bug fixes and net-next for
development (anything that is not a bug fix). Each patch should specify
which tree the patch is for by putting 'net' or 'net-next' in the
brackets ([]). This is a cleanup not a bug fix, so this patch should be:

[PATCH net-next] ipv6: remove unused local variable

and really that should be

[PATCH net-next] ipv6: remove unnecessary local variable

If you send more versions of a patch always put a changelog - a summary
of what is different in the current patch versus the previous ones.

No need to send another version of this patch unless you get a comment
requesting change, or the maintainers ask for a re-send.

Reviewed-by: David Ahern <dsahern@...nel.org>