netdev - Re: [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUCe=r9gwa91SFjueqYmoOg2TFsym22RNBJbjunOgrWVw@mail.gmail.com>
Date:   Thu, 15 Jul 2021 08:17:11 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Qitao Xu <qitao.xu@...edance.com>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch net-next resend v2] net_sched: use %px to print skb
 address in trace_qdisc_dequeue()

On Thu, Jul 15, 2021 at 4:26 AM Yunsheng Lin <linyunsheng@...wei.com> wrote:
>
> On 2021/7/15 14:00, Cong Wang wrote:
> > From: Qitao Xu <qitao.xu@...edance.com>
> >
> > Print format of skbaddr is changed to %px from %p, because we want
> > to use skb address as a quick way to identify a packet.
> >
> > Note, trace ring buffer is only accessible to privileged users,
> > it is safe to use a real kernel address here.
>
> Does it make more sense to use %pK?
>
> see: https://lwn.net/Articles/420403/

I think you have the answer:

+ * %pK cannot be used in IRQ context because it tests
+ * CAP_SYSLOG.

;) So, no.

Thanks.