netdev - Re: [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <536718b6-0735-cc03-6268-c6a130b55ba7@huawei.com>
Date:   Thu, 15 Jul 2021 19:26:39 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, <netdev@...r.kernel.org>
CC:     Qitao Xu <qitao.xu@...edance.com>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch net-next resend v2] net_sched: use %px to print skb
 address in trace_qdisc_dequeue()

On 2021/7/15 14:00, Cong Wang wrote:
> From: Qitao Xu <qitao.xu@...edance.com>
> 
> Print format of skbaddr is changed to %px from %p, because we want
> to use skb address as a quick way to identify a packet.
> 
> Note, trace ring buffer is only accessible to privileged users,
> it is safe to use a real kernel address here.

Does it make more sense to use %pK?

see: https://lwn.net/Articles/420403/

> 
> Reviewed-by: Cong Wang <cong.wang@...edance.com>
> Signed-off-by: Qitao Xu <qitao.xu@...edance.com>
> ---
>  include/trace/events/qdisc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h
> index 330d32d84485..58209557cb3a 100644
> --- a/include/trace/events/qdisc.h
> +++ b/include/trace/events/qdisc.h
> @@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue,
>  		__entry->txq_state	= txq->state;
>  	),
>  
> -	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p",
> +	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px",
>  		  __entry->ifindex, __entry->handle, __entry->parent,
>  		  __entry->txq_state, __entry->packets, __entry->skbaddr )
>  );
>