netdev - Re: [PATCH net 2/2] sctp: send pmtu probe only if packet loss in Search Complete state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210720125036.29ed23ba@cakuba>
Date:   Tue, 20 Jul 2021 12:50:36 +0200
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        linux-sctp@...r.kernel.org,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        timo.voelker@...muenster.de
Subject: Re: [PATCH net 2/2] sctp: send pmtu probe only if packet loss in
 Search Complete state

On Mon, 19 Jul 2021 12:53:23 -0400, Xin Long wrote:
> This patch is to introduce last_rtx_chunks into sctp_transport to detect
> if there's any packet retransmission/loss happened by checking against
> asoc's rtx_data_chunks in sctp_transport_pl_send().
> 
> If there is, namely, transport->last_rtx_chunks != asoc->rtx_data_chunks,
> the pmtu probe will be sent out. Otherwise, increment the pl.raise_count
> and return when it's in Search Complete state.
> 
> With this patch, if in Search Complete state, which is a long period, it
> doesn't need to keep probing the current pmtu unless there's data packet
> loss. This will save quite some traffic.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Can we get a Fixes tag, please?