netdev - Re: [Patch net-next] net_sched: refactor TC action init API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e6cd365-fda6-7329-78ad-e0ebe9068f28@mojatatu.com>
Date:   Wed, 21 Jul 2021 12:04:55 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     Cong Wang <cong.wang@...edance.com>,
        Vlad Buslov <vladbu@...dia.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Patch net-next] net_sched: refactor TC action init API

On 2021-07-20 7:34 p.m., Cong Wang wrote:
> From: Cong Wang<cong.wang@...edance.com>
> 
> TC action ->init() API has 10 parameters, it becomes harder
> to read. Some of them are just boolean and can be replaced
> by flags. Similarly for the internal API tcf_action_init()
> and tcf_exts_validate().
> 
> This patch converts them to flags and fold them into
> the upper 16 bits of "flags", whose lower 16 bits are still
> reserved for user-space. More specifically, the following
> kernel flags are introduced:
> 
> TCA_ACT_FLAGS_POLICE replace 'name' in a few contexts, to
> distinguish whether it is compatible with policer.
> 
> TCA_ACT_FLAGS_BIND replaces 'bind', to indicate whether
> this action is bound to a filter.
> 
> TCA_ACT_FLAGS_REPLACE  replaces 'ovr' in most contexts,
> means we are replacing an existing action.
> 
> TCA_ACT_FLAGS_NO_RTNL replaces 'rtnl_held' but has the
> opposite meaning, because we still hold RTNL in most
> cases.
> 
> The only user-space flag TCA_ACT_FLAGS_NO_PERCPU_STATS is
> untouched and still stored as before.
> 
> I have tested this patch with tdc and I do not see any
> failure related to this patch.
> 
> Cc: Vlad Buslov<vladbu@...dia.com>
> Cc: Jamal Hadi Salim<jhs@...atatu.com>
> Cc: Jiri Pirko<jiri@...nulli.us>
> Signed-off-by: Cong Wang<cong.wang@...edance.com>
> ---

Looks good to me.
Acked-by: Jamal Hadi Salim<jhs@...atatu.com>

cheers,
jamal