netdev - Re: [PATCH net-next] docs: networking: dpaa2: add documentation for the switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Jul 2021 17:10:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        corbet@....net, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next] docs: networking: dpaa2: add documentation for
 the switch driver

> > Are these requirements tested? Will the driver fail probe if they are
> > not met?
> 
> Yes, they are tested.
> 
> If the DPSW object configuration does not meet the requirements, the
> driver will error out on probe with a message explictly saying what
> is happening.

Good. Maybe reference that here, so somebody googling the error
message lands on this document.

> On the other hand, I think this section might give too much details on
> the actual implementation (I took it from the commit message of the
> patch adding the support). Might as well just remove it and add the
> example.
> 
> All that I was trying to say is that the filters will not be added in
> the ACL table with the explicit priority specified by the user but
> rather with one determined based on all the rules currently present in
> the table.
> Nothing is unusual in the usage, the order in which the rules are
> executed will be respected.

So if it is an implementation detail, it probably is not relevant
here.

	Andrew