netdev - Re: [PATCH v2 1/4] selftests: add tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Jul 2021 10:32:50 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Shuah Khan <skhan@...uxfoundation.org>, tj@...nel.org,
        shuah@...nel.org, akpm@...ux-foundation.org, rafael@...nel.org,
        davem@...emloft.net, kuba@...nel.org, ast@...nel.org,
        andriin@...com, daniel@...earbox.net, atenart@...nel.org,
        alobakin@...me, weiwan@...gle.com, ap420073@...il.com,
        jeyu@...nel.org, ngupta@...are.org,
        sergey.senozhatsky.work@...il.com, minchan@...nel.org,
        axboe@...nel.dk, mbenes@...e.com, jpoimboe@...hat.com,
        tglx@...utronix.de, keescook@...omium.org, jikos@...nel.org,
        rostedt@...dmis.org, peterz@...radead.org,
        linux-block@...r.kernel.org, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] selftests: add tests_sysfs module

On Fri, Jul 23, 2021 at 12:38:27PM +0200, Greg KH wrote:
> On Thu, Jul 22, 2021 at 03:34:49PM -0700, Luis Chamberlain wrote:
> > kunit relies on UML and UML is a simple one core architecture, to start
> > with.
> 
> I thought the UML requirement was long gone, are you sure it is still
> present?

It's *the* way to run kunit.

> > This means I cannot run tests for multicore with it, which is
> > where many races do happen! Yes, you can run kunit on other
> > architectures, but all that is new.
> 
> What do you mean by "new"?  It should work today, in today's kernel
> tree, right?

That was experimental. And I know no one using it.

> > In this case kunit is not ideal given I want to mimic something in
> > userspace interaction, and expose races through error injection and
> > if we can use as many cores to busy races out.
> 
> Can you not do that with kunit?  If not, why not?

kunit requires codifying everything in C, what we need is a lot of
flexibility to do all sorts of races in userspace, and actually use
userspace tools.

I am *not* going to even try to rewrite my selftest as a kunit test.
It is just not going to happen.

  Luis