netdev - Re: [PATCH v5 net-next 22/36] net: Add ulp_ddp_pdu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaa53cb5-f9ee-1402-b653-662a4c220a8d@grimberg.me>
Date:   Fri, 23 Jul 2021 12:42:33 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Boris Pismenny <borisp@...dia.com>, dsahern@...il.com,
        kuba@...nel.org, davem@...emloft.net, saeedm@...dia.com,
        hch@....de, axboe@...com, kbusch@...nel.org,
        viro@...iv.linux.org.uk, edumazet@...gle.com, smalin@...vell.com
Cc:     boris.pismenny@...il.com, linux-nvme@...ts.infradead.org,
        netdev@...r.kernel.org, benishay@...dia.com, ogerlitz@...dia.com,
        yorayz@...dia.com
Subject: Re: [PATCH v5 net-next 22/36] net: Add ulp_ddp_pdu_info struct


> +/**
> + * struct ulp_ddp_pdu_info - pdu info for tcp ddp crc Tx offload.
> + *
> + * @end_seq:	tcp seq of the last byte in the pdu.
> + * @start_seq:	tcp seq of the first byte in the pdu.
> + * @data_len:	pdu data size (in bytes).
> + * @hdr_len:	the size (in bytes) of the pdu header.
> + * @hdr:	pdu header.
> + * @req:	the ulp request for the original pdu.
> + */
> +struct ulp_ddp_pdu_info {
> +	struct list_head list;
> +	u32		end_seq;
> +	u32		start_seq;
> +	u32		data_len;
> +	u32		hdr_len;
> +	void		*hdr;
> +	struct request	*req;

Not sure what ddp does with this, but it shouldn't accept struct
request what-so-ever.